Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop deprecated protx *_hpmn RPC entry points in favor of protx *_evo #6247

Merged
merged 1 commit into from
Sep 26, 2024
Merged

feat: drop deprecated protx *_hpmn RPC entry points in favor of protx *_evo #6247

merged 1 commit into from
Sep 26, 2024

Conversation

knst
Copy link
Collaborator

@knst knst commented Sep 3, 2024

What was done?

Drop deprecated protx *_hpmn RPC entry points in favor of protx *_evo

Full list of removed composite RPC:

  • protx register_fund_hpmn
  • protx register_hpmn
  • protx register_prepare_hpmn
  • protx update_service_hpmn

How Has This Been Tested?

platform still uses it, need to replace _hpmn suffixes to _evo and remove -deprecated_hpmn from dash.conf

shumkov please be notified that mentioned RPC are going to be removed in Dash Core v22 as deprecated, this PR requires your approval

Breaking Changes

Removed RPC:

  • protx register_fund_hpmn
  • protx register_hpmn
  • protx register_prepare_hpmn
  • protx update_service_hpmn

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 22 milestone Sep 3, 2024
PastaPastaPasta
PastaPastaPasta requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add release notes

@PastaPastaPasta PastaPastaPasta marked this pull request as draft September 5, 2024 19:05
@knst
feat: drop deprecated protx_*_hpmn RPC entry points in favor of protx…
6f0b546 
…_*_evo

Full list of removed composite RPC:
  protx register_fund_hpmn
  protx register_hpmn
  protx register_prepare_hpmn
  protx update_service_hpmn
@knst knst force-pushed the v22-deprecate-hpmn branch from cb81886 to 6f0b546 Compare September 26, 2024 07:06
@knst knst marked this pull request as ready for review September 26, 2024 07:06
UdjinM6
UdjinM6 approved these changes Sep 26, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 6f0b546

PastaPastaPasta
PastaPastaPasta approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 6f0b546

@PastaPastaPasta PastaPastaPasta merged commit d8da094 into dashpay:develop Sep 26, 2024
27 checks passed
@shumkov shumkov mentioned this pull request Sep 27, 2024
Merged
6 tasks
@thephez thephez added the RPC Some notable changes to RPC params/behaviour/descriptions label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@shumkov shumkov Awaiting requested review from shumkov

Assignees
No one assigned
Labels
RPC Some notable changes to RPC params/behaviour/descriptions
Projects
None yet
Milestone
22
Development

Successfully merging this pull request may close these issues.
4 participants
@knst @UdjinM6 @PastaPastaPasta @thephez